feat: give context on previous reviews for successive review requests #263

Merged

davide merged 6 commits from feat/successive-review-context into main 2026-09-12 12:45:44 +00:00

Conversation 3 Commits 6 Files changed 17 +573 -37

ci-bot commented 2026-09-08 16:04:09 +00:00

Member

• Copy link
• Copy Markdown

Closes #165

When the agent is assigned as a reviewer again on a pull request it has already reviewed, it now gets the full history of its previous reviews in the prompt:

• Previous reviews — author, verdict (state), reviewed commit, and summary body.
• Inline review comments — path, line, author, and body for each comment.

The prompt also instructs the agent to check the current code against each previously raised issue: acknowledge the ones that are fixed, re-raise the ones still open, and look for new issues introduced since the last review.

Changes

• src/schemas.ts — extended prReviewSchema and prReviewCommentSchema with author, verdict, commit, timestamps, path and line; added prReviewWithCommentsSchema.
• src/forgejo/index.ts — added getPrReviewsWithComments() which fetches all PR reviews together with their inline comments.
• src/context.ts — fetches previous reviews (with comments) on pull_request_review_requested events and exposes them in the event context.
• src/prompt.ts — renders the previous reviews section and adds successive-review guidance when previous reviews exist.

Closes #165 When the agent is assigned as a reviewer again on a pull request it has already reviewed, it now gets the full history of its previous reviews in the prompt: - **Previous reviews** — author, verdict (`state`), reviewed commit, and summary body. - **Inline review comments** — path, line, author, and body for each comment. The prompt also instructs the agent to check the current code against each previously raised issue: acknowledge the ones that are fixed, re-raise the ones still open, and look for new issues introduced since the last review. ## Changes - `src/schemas.ts` — extended `prReviewSchema` and `prReviewCommentSchema` with author, verdict, commit, timestamps, path and line; added `prReviewWithCommentsSchema`. - `src/forgejo/index.ts` — added `getPrReviewsWithComments()` which fetches all PR reviews together with their inline comments. - `src/context.ts` — fetches previous reviews (with comments) on `pull_request_review_requested` events and exposes them in the event context. - `src/prompt.ts` — renders the previous reviews section and adds successive-review guidance when previous reviews exist.

ci-bot added 1 commit 2026-09-08 16:04:09 +00:00

feat: give context on previous reviews for successive review requests b2071e632b

ci-bot referenced this pull request 2026-09-08 16:04:22 +00:00

feat: handle successive review requests in PRs #165

davide commented 2026-09-09 14:05:07 +00:00

Owner

• Copy link
• Copy Markdown

TODO: getPrReviews should skip reviews that are pending, since they don't add value.

TODO: getPrReviews should skip reviews that are pending, since they don't add value.

davide commented 2026-09-11 13:07:58 +00:00

Owner

• Copy link
• Copy Markdown

@ci-bot in the main branch there was some work and now there's a testing infrastrucure that has been set up. Can you get this up to date with its own tests?

For integration tests, you can write, but not run them since you don't have access to a testing forgejo instance. I will verify them in a following review.

@ci-bot in the main branch there was some work and now there's a testing infrastrucure that has been set up. Can you get this up to date with its own tests? For integration tests, you can write, but not run them since you don't have access to a testing forgejo instance. I will verify them in a following review.

ci-bot added 2 commits 2026-09-11 13:13:38 +00:00

merge: integrate main with testing infrastructure 993d744a33

feat: skip pending reviews and add tests for successive review context ... 92b3c9e704

- getPrReviews now filters out PENDING reviews (drafts carry no verdict)
- add unit tests for the review schemas, prompt rendering, context
  assembly and the pending-review filtering
- add integration tests for getPrReviewsWithComments and the review
  context (to be run against a real Forgejo instance)

ci-bot commented 2026-09-11 13:13:48 +00:00

Author

Member

• Copy link
• Copy Markdown

Done — the branch is now up to date with main and has its own tests.

Changes

1. Pending reviews skipped (TODO from review)
getPrReviews now filters out reviews with state === "PENDING" — drafts carry no verdict, so they add no value to the review history. getPrReviewsWithComments inherits this, so it never fetches comments for pending reviews.

2. Merged main and adapted the feature
The branch was rebased onto the current main (ApiContext refactor, search tools, vitest infrastructure). The feature was adapted to the new structure:

• getPrReviewsWithComments(apiCtx, repo, prId) follows the new client signature
• extended prReviewSchema / prReviewCommentSchema and prReviewWithCommentsSchema kept
• context fetches reviews only on pull_request_review_requested events

3. Unit tests (all passing — 54 tests)

• src/test/unit/forgejo.test.ts (new) — pending-review filtering and getPrReviewsWithComments composition (mocks forgejoFetch)
• src/test/unit/schemas.test.ts — review/comment/with-comments schemas
• src/test/unit/prompt.test.ts — successive-review guidance and previous-reviews rendering (incl. comment without line)
• src/test/unit/context.test.ts — reviews fetched on review requests, not on other events
• src/test/fixtures.ts — added mockReview and mockReviewRequestedEventCtx

4. Integration tests (written, not run — no Forgejo instance here)

• src/test/integration/forgejo.test.ts — getPrReviewsWithComments returns reviews with their inline comments; pending reviews are skipped (posted via raw forgejoFetch since postPrReview only accepts submitted events)
• src/test/integration/context.test.ts — getEventContext includes previous reviews with comments on a review request

5. README — documented the successive-review feature.

Verified locally: pnpm check, pnpm lint:check, pnpm format:check, pnpm test:unit, pnpm build all pass. The integration tests are ready for you to verify against the real instance.

Done — the branch is now up to date with `main` and has its own tests. ## Changes **1. Pending reviews skipped (TODO from review)** `getPrReviews` now filters out reviews with `state === "PENDING"` — drafts carry no verdict, so they add no value to the review history. `getPrReviewsWithComments` inherits this, so it never fetches comments for pending reviews. **2. Merged `main` and adapted the feature** The branch was rebased onto the current `main` (ApiContext refactor, search tools, vitest infrastructure). The feature was adapted to the new structure: - `getPrReviewsWithComments(apiCtx, repo, prId)` follows the new client signature - extended `prReviewSchema` / `prReviewCommentSchema` and `prReviewWithCommentsSchema` kept - context fetches reviews only on `pull_request_review_requested` events **3. Unit tests (all passing — 54 tests)** - `src/test/unit/forgejo.test.ts` (new) — pending-review filtering and `getPrReviewsWithComments` composition (mocks `forgejoFetch`) - `src/test/unit/schemas.test.ts` — review/comment/with-comments schemas - `src/test/unit/prompt.test.ts` — successive-review guidance and previous-reviews rendering (incl. comment without line) - `src/test/unit/context.test.ts` — reviews fetched on review requests, not on other events - `src/test/fixtures.ts` — added `mockReview` and `mockReviewRequestedEventCtx` **4. Integration tests (written, not run — no Forgejo instance here)** - `src/test/integration/forgejo.test.ts` — `getPrReviewsWithComments` returns reviews with their inline comments; pending reviews are skipped (posted via raw `forgejoFetch` since `postPrReview` only accepts submitted events) - `src/test/integration/context.test.ts` — `getEventContext` includes previous reviews with comments on a review request **5. README** — documented the successive-review feature. Verified locally: `pnpm check`, `pnpm lint:check`, `pnpm format:check`, `pnpm test:unit`, `pnpm build` all pass. The integration tests are ready for you to verify against the real instance.

davide added 1 commit 2026-09-11 13:44:38 +00:00

chore: update prompt c057a09241

davide added 1 commit 2026-09-11 13:46:33 +00:00

chore: remove unnecessary schema cdf4f3b7b0

davide added 1 commit 2026-09-12 12:45:25 +00:00

chore: add reviewer test user ce2f99aca0

davide scheduled this pull request to auto merge when all checks succeed 2026-09-12 12:45:33 +00:00

davide merged commit 536d464b10 into main 2026-09-12 12:45:44 +00:00

davide deleted branch feat/successive-review-context 2026-09-12 12:45:45 +00:00

davide referenced this pull request from a commit 2026-09-12 12:45:46 +00:00

feat: give context on previous reviews for successive review requests (#263)

renovate-bot referenced this pull request from projects/events-cash-register 2026-09-13 03:01:57 +00:00

ci(deps): update ci dependencies #255

renovate-bot referenced this pull request 2026-09-13 03:02:34 +00:00

ci(deps): update ci dependencies #284

renovate-bot referenced this pull request from projects/kube-dns-rs 2026-09-13 03:02:46 +00:00

chore(deps): update https://git.zarantonello.dev/projects/forgejo-agent action to v1.11.0 #46

renovate-bot referenced this pull request from university/notes 2026-09-13 03:04:26 +00:00

ci(deps): update ci dependencies #993

renovate-bot referenced this pull request from davide/website 2026-09-13 03:07:00 +00:00

ci(deps): update ci dependencies #39

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

projects/forgejo-agent!263

No description provided.