chore: add scaffolding for libcups native module #43

Merged

davide merged 10 commits from chore/libcups-setup into main 2026-07-01 13:30:49 +00:00

Conversation 3 Commits 10 Files changed 19 +194 -49

davide commented 2026-06-30 22:11:45 +00:00

Owner

Copy link

TODO:

• Add clang tools extra to check with clang format and clang tidy
• Update ci workflows

TODO: - [x] Add clang tools extra to check with clang format and clang tidy - [x] Update ci workflows

davide added 1 commit 2026-06-30 22:11:46 +00:00

chore: add scaffolding for libcups native module cd68848b62

davide added 1 commit 2026-07-01 12:01:14 +00:00

chore: switch from cmake-js to meson f09c491a9e

davide added 3 commits 2026-07-01 12:12:14 +00:00

Merge remote-tracking branch 'origin/main' into chore/libcups-setup c952a15be7

Merge remote-tracking branch 'origin/main' into chore/libcups-setup ca8b5ad048

chore: update ci image tags 90897054e3

davide added 1 commit 2026-07-01 12:28:39 +00:00

chore: use pnpm run -r 9d22cfefd7

davide added 1 commit 2026-07-01 12:33:49 +00:00

ci: add setup step da07b6b671

davide added 1 commit 2026-07-01 12:35:52 +00:00

ci: add aggregate output 542fcc1e60

davide commented 2026-07-01 12:37:06 +00:00

Author

Owner

Copy link

@llm-bot can you check if README.md and AGENTS.md need updates, probably need to instruct to use pnpm -r like in the ci scripts.

@llm-bot can you check if README.md and AGENTS.md need updates, probably need to instruct to use pnpm -r like in the ci scripts.

llm-bot added 1 commit 2026-07-01 12:52:17 +00:00

docs: update README and AGENTS for pnpm workspace usage 6a5323adaf

llm-bot commented 2026-07-01 12:53:17 +00:00

Member

Copy link

Good catch! I've updated both README.md and AGENTS.md to reflect the pnpm workspace usage:

README.md changes:

• Updated the "Getting Started" build command from manual cd to pnpm run -r --aggregate-output build, matching the CI workflows

AGENTS.md changes:

• Added a note explaining this is a pnpm workspace (root + cups/)
• Updated all cross-workspace scripts (format:check, format:fix, lint:check, lint:fix) to use pnpm run -r
• Kept pnpm check and pnpm test as root-only commands (they don't exist in the cups/ workspace)
• Added a section for running scripts only in the cups/ workspace

These changes align the documentation with how the CI workflows actually execute commands.

Good catch! I've updated both `README.md` and `AGENTS.md` to reflect the pnpm workspace usage: **README.md changes:** - Updated the "Getting Started" build command from manual `cd` to `pnpm run -r --aggregate-output build`, matching the CI workflows **AGENTS.md changes:** - Added a note explaining this is a pnpm workspace (root + `cups/`) - Updated all cross-workspace scripts (`format:check`, `format:fix`, `lint:check`, `lint:fix`) to use `pnpm run -r` - Kept `pnpm check` and `pnpm test` as root-only commands (they don't exist in the `cups/` workspace) - Added a section for running scripts only in the `cups/` workspace These changes align the documentation with how the CI workflows actually execute commands.

davide added 1 commit 2026-07-01 12:59:03 +00:00

chore: remove extra section from agents.md 1b05568ce9

davide requested review from llm-bot 2026-07-01 12:59:14 +00:00

llm-bot approved these changes 2026-07-01 13:23:38 +00:00

llm-bot left a comment

Copy link

PR Review: chore: add scaffolding for libcups native module

Overall, this is a well-structured PR that adds solid scaffolding for the libcups native module. The documentation updates are accurate and align with the CI workflows.

✅ Positive Findings

Documentation (README.md & AGENTS.md)

• Both files correctly reflect the pnpm workspace structure (root + cups/)
• pnpm run -r commands are properly documented for cross-workspace operations
• pnpm check and pnpm test are correctly noted as root-only commands
• README.md build command matches the CI workflow pattern (pnpm run -r --aggregate-output build)
• AGENTS.md provides clear guidance on when to use pnpm run -r vs root-only commands

libcups Scaffolding

• Clean meson.build configuration with proper include paths and dependency detection
• Well-configured .clang-tidy with sensible checks and naming conventions (CamelCase for structs, pascalCase for functions, UPPER_CASE for constants)
• .clang-format using Chromium style — consistent and appropriate
• Proper .gitignore entry for /cups/build/ to exclude build artifacts
• binding.ts correctly uses createRequire for loading the native .node module
• pnpm-workspace.yaml properly configured with includeWorkspaceRoot: true

CI Workflows

• All workflows consistently use pnpm run -r --no-sort --aggregate-output for cross-workspace commands
• The setup script is run before other commands, ensuring .env is configured

ℹ️ Minor Observations

1. README.md project structure simplification: The component subdirectory detail was removed from the diagram (e.g., controls/, dialog/, form/, etc.). This is a reasonable simplification but may make it slightly harder for new contributors to understand the component organization at a glance. Consider adding a cross-reference to AGENTS.md or keeping a minimal subset.

2. CI flags vs documentation: The CI workflows use --no-sort --aggregate-output but the documentation only mentions --aggregate-output. This is fine — --no-sort is a CI optimization that's not needed for local development.

3. Devcontainer TODO: There's a TODO: mock cups server comment in docker-compose.yml. This is noted but not blocking — it's good that this is tracked.

✅ Conclusion

Approved. The PR is well-executed, the documentation accurately reflects the new workspace structure, and the libcups scaffolding is properly set up for future development.

## PR Review: chore: add scaffolding for libcups native module Overall, this is a well-structured PR that adds solid scaffolding for the libcups native module. The documentation updates are accurate and align with the CI workflows. ### ✅ Positive Findings **Documentation (README.md & AGENTS.md)** - Both files correctly reflect the pnpm workspace structure (root + `cups/`) - `pnpm run -r` commands are properly documented for cross-workspace operations - `pnpm check` and `pnpm test` are correctly noted as root-only commands - README.md build command matches the CI workflow pattern (`pnpm run -r --aggregate-output build`) - AGENTS.md provides clear guidance on when to use `pnpm run -r` vs root-only commands **libcups Scaffolding** - Clean meson.build configuration with proper include paths and dependency detection - Well-configured `.clang-tidy` with sensible checks and naming conventions (CamelCase for structs, pascalCase for functions, UPPER_CASE for constants) - `.clang-format` using Chromium style — consistent and appropriate - Proper `.gitignore` entry for `/cups/build/` to exclude build artifacts - `binding.ts` correctly uses `createRequire` for loading the native `.node` module - `pnpm-workspace.yaml` properly configured with `includeWorkspaceRoot: true` **CI Workflows** - All workflows consistently use `pnpm run -r --no-sort --aggregate-output` for cross-workspace commands - The `setup` script is run before other commands, ensuring `.env` is configured ### ℹ️ Minor Observations 1. **README.md project structure simplification**: The component subdirectory detail was removed from the diagram (e.g., `controls/`, `dialog/`, `form/`, etc.). This is a reasonable simplification but may make it slightly harder for new contributors to understand the component organization at a glance. Consider adding a cross-reference to AGENTS.md or keeping a minimal subset. 2. **CI flags vs documentation**: The CI workflows use `--no-sort --aggregate-output` but the documentation only mentions `--aggregate-output`. This is fine — `--no-sort` is a CI optimization that's not needed for local development. 3. **Devcontainer TODO**: There's a `TODO: mock cups server` comment in `docker-compose.yml`. This is noted but not blocking — it's good that this is tracked. ### ✅ Conclusion **Approved.** The PR is well-executed, the documentation accurately reflects the new workspace structure, and the libcups scaffolding is properly set up for future development.

davide merged commit 00aa754e22 into main 2026-07-01 13:30:49 +00:00

davide deleted branch chore/libcups-setup 2026-07-01 13:30:49 +00:00

davide referenced this pull request from a commit 2026-07-01 13:30:50 +00:00

chore: add scaffolding for libcups native module (#43)

Sign in to join this conversation.

Reviewers

No reviewers

llm-bot

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

projects/events-cash-register!43

No description provided.